-
-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: net8 unknown stack trace methods for JIT methods #3942
Conversation
// | StopEnumeration | Security | AppDomainResourceManagement | Exception | Threading | Contention | Stack | JittedMethodILToNativeMap | ||
// | ThreadTransfer | GCHeapAndTypeNames | Codesymbols | Compilation, | ||
new EventPipeProvider(ClrTraceEventParser.ProviderName, EventLevel.Informational, (long) ClrTraceEventParser.Keywords.Default), | ||
new EventPipeProvider(ClrTraceEventParser.ProviderName, EventLevel.Verbose, (long) ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EventLevel.Verbose
is the actual fix here. The rest of the change is just an improvement so we don't receive things we don't need.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- net8 unknown stack trace methods for JIT methods ([#3942](https://github.com/getsentry/sentry-dotnet/pull/3942)) If none of the above apply, you can opt out of this check by adding |
* Revert "Skip flaky test (EventPipeSession_ReceivesExpectedCLREvents) (#3949)" This reverts commit 50e5232. * Revert "fix: net8 unknown stack trace methods for JIT methods (#3942)" This reverts commit d197cb2. * Revert "chore: profiling improvements (#3941)" This reverts commit bea672a. * chore: revert changelog * Verify tests * Windows verify tests --------- Co-authored-by: James Crosswell <[email protected]>
This got reverted but it's in the changelog: 7faf221...refs/heads/release/5.1.1 |
yeah these changelog items got accidently pulled back in when James was updating the revert PR and pulled changes from main and while I've noticed this yesterday and fixed it in another PR, I didn't check whether there's already a release triggered. Sorry about the mess, I could have checked if someone triggered the release and closed the publish issue... I've updated the changelog in the release but there's nothing we can do about the tagged changelog.md |
Fixes #3924