Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: net8 unknown stack trace methods for JIT methods #3942

Merged
merged 6 commits into from
Feb 7, 2025

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented Feb 6, 2025

Fixes #3924

// | StopEnumeration | Security | AppDomainResourceManagement | Exception | Threading | Contention | Stack | JittedMethodILToNativeMap
// | ThreadTransfer | GCHeapAndTypeNames | Codesymbols | Compilation,
new EventPipeProvider(ClrTraceEventParser.ProviderName, EventLevel.Informational, (long) ClrTraceEventParser.Keywords.Default),
new EventPipeProvider(ClrTraceEventParser.ProviderName, EventLevel.Verbose, (long) (
Copy link
Collaborator Author

@vaind vaind Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EventLevel.Verbose is the actual fix here. The rest of the change is just an improvement so we don't receive things we don't need.

@vaind vaind marked this pull request as ready for review February 6, 2025 18:43
Copy link
Collaborator

@jamescrosswell jamescrosswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@vaind vaind merged commit d197cb2 into main Feb 7, 2025
11 of 12 checks passed
@vaind vaind deleted the fix/profiling-net8-unknow-stack-frames branch February 7, 2025 06:37
Copy link
Contributor

github-actions bot commented Feb 7, 2025

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- net8 unknown stack trace methods for JIT methods ([#3942](https://github.com/getsentry/sentry-dotnet/pull/3942))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against c809fe4

vaind added a commit that referenced this pull request Feb 11, 2025
vaind added a commit that referenced this pull request Feb 12, 2025
@vaind vaind mentioned this pull request Feb 12, 2025
jamescrosswell added a commit that referenced this pull request Feb 13, 2025
* Revert "Skip flaky test (EventPipeSession_ReceivesExpectedCLREvents) (#3949)"

This reverts commit 50e5232.

* Revert "fix: net8 unknown stack trace methods for JIT methods (#3942)"

This reverts commit d197cb2.

* Revert "chore: profiling improvements (#3941)"

This reverts commit bea672a.

* chore: revert changelog

* Verify tests

* Windows verify tests

---------

Co-authored-by: James Crosswell <[email protected]>
@bruno-garcia
Copy link
Member

This got reverted but it's in the changelog: 7faf221...refs/heads/release/5.1.1

@vaind
Copy link
Collaborator Author

vaind commented Feb 14, 2025

This got reverted but it's in the changelog: 7faf221...refs/heads/release/5.1.1

yeah these changelog items got accidently pulled back in when James was updating the revert PR and pulled changes from main and while I've noticed this yesterday and fixed it in another PR, I didn't check whether there's already a release triggered. Sorry about the mess, I could have checked if someone triggered the release and closed the publish issue... I've updated the changelog in the release but there's nothing we can do about the tagged changelog.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Profiling - unknown stacks on net8
3 participants