Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2710 - Return macOS instead of 'Darwin' and return proper version #3956

Merged
merged 8 commits into from
Feb 12, 2025

Conversation

aritchie
Copy link
Collaborator

Resolves #2710

Enricher will now check if running in a mac environment (runtime as we don't target mac targetframework) and switch "Darin" to "macOS" as well as set the operating system version properly

NOTES:

  • The native library was using compiler checks. This was an easier route for the dotnet repo instead of pinvoking.
  • Adds a PlatformFact for xunit, so we can skip tests based on platform

Copy link
Collaborator

@jamescrosswell jamescrosswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as soon as all the CI checks are green.

Thanks @aritchie !

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally would go on a major bump because technically breaks saved search and tag distribution based on that OS tag. But I'd say unlikely to be a real disruption and the value of the change is worth the risk.

@aritchie aritchie merged commit ee62bb9 into main Feb 12, 2025
22 checks passed
@aritchie aritchie deleted the 2710-macos_version branch February 12, 2025 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

macOS version not reported
3 participants