-
-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #2710 - Return macOS instead of 'Darwin' and return proper version #3956
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as soon as all the CI checks are green.
Thanks @aritchie !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ideally would go on a major bump because technically breaks saved search and tag distribution based on that OS tag. But I'd say unlikely to be a real disruption and the value of the change is worth the risk.
Resolves #2710
Enricher will now check if running in a mac environment (runtime as we don't target mac targetframework) and switch "Darin" to "macOS" as well as set the operating system version properly
NOTES: