Skip to content

ref(skills): remove sentry-sdk-upgrade and dissolve the workflow router#287

Open
evanpurkhiser wants to merge 1 commit into
mainfrom
evanpurkhiser/ref-skills-remove-sentry-sdk-upgrade-and-dissolve-the-workflow-router
Open

ref(skills): remove sentry-sdk-upgrade and dissolve the workflow router#287
evanpurkhiser wants to merge 1 commit into
mainfrom
evanpurkhiser/ref-skills-remove-sentry-sdk-upgrade-and-dissolve-the-workflow-router

Conversation

@evanpurkhiser

Copy link
Copy Markdown
Member

Major-version SDK upgrades are a rare, low-frequency task and don't fit the task-shaped skill set the getting-started redesign is converging on. Removing sentry-sdk-upgrade empties the sentry-workflow router — it was the only child left after the code-review skills were removed in #283 — so this dissolves the router too.

Deletes both skills, their README/AGENTS listings, and the workflow entries in the AGENTS skill-tree navigation, then regenerates SKILL_TREE.md. sentry-feature-setup is now the last remaining router as the library migrates toward flat standalone skills. build-skill-tree.sh --check passes (8 skills, 1 router, 0 errors).

Note: this and the open #286 both regenerate SKILL_TREE.md, so whichever merges second needs a trivial regen of that generated file.

Major-version SDK upgrades are a rare, low-frequency task and don't fit the
task-shaped skill set the getting-started redesign is converging on. Removing
sentry-sdk-upgrade empties the sentry-workflow router (its only remaining child
after the code-review skills were removed in #283), so drop the router too.

Delete both skills, the README/AGENTS listings, and the workflow entries in the
AGENTS skill-tree navigation, then regenerate SKILL_TREE.md. sentry-feature-setup
is now the last router as the library migrates toward flat standalone skills.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit ef57592. Configure here.

Comment thread src/SKILL_TREE.md

| Use when | Skill |
|---|---|
| Upgrade the Sentry JavaScript SDK across major versions | [`sentry-sdk-upgrade`](skills/sentry-sdk-upgrade/SKILL.md) |

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrade prompt lacks skill

Medium Severity

After removing sentry-sdk-upgrade, the regenerated SKILL_TREE.md still tells agents to offer Upgrade Sentry SDK in “Start Here,” but the Workflows table below has no matching skill row. Users who pick that option get no skill to load from the index.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit ef57592. Configure here.

Comment thread src/SKILL_TREE.md
Comment on lines 37 to 42

| Use when | Skill |
|---|---|
| Upgrade the Sentry JavaScript SDK across major versions | [`sentry-sdk-upgrade`](skills/sentry-sdk-upgrade/SKILL.md) |

## Feature Setup

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The "Upgrade Sentry SDK" menu option in src/SKILL_TREE.md points to the sentry-sdk-upgrade skill, which has been deleted. The option is hardcoded in scripts/build-skill-tree.sh.
Severity: MEDIUM

Suggested Fix

Remove the hardcoded "Upgrade Sentry SDK" list item from the HEADER heredoc in scripts/build-skill-tree.sh (around line 228). After updating the script, regenerate the src/SKILL_TREE.md file to reflect the change.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: src/SKILL_TREE.md#L37-L42

Potential issue: The `SKILL_TREE.md` file, which is used by AI agents to guide users,
contains a menu option for "Upgrade Sentry SDK". However, the corresponding
`sentry-sdk-upgrade` skill has been deleted in this pull request. The menu option is
hardcoded in the generation script `scripts/build-skill-tree.sh` and was not removed.
When a user selects this option via an agent, the agent will be unable to find the
skill, resulting in a broken user flow. The script's validation checks do not cover
these hardcoded menu options.

Also affects:

  • scripts/build-skill-tree.sh:228

Did we get this right? 👍 / 👎 to inform future reviews.

@sergical

Copy link
Copy Markdown
Member

fwiw i pulled some stats before this skill was created that suggested that a large chunk of installs were on versions 7, 8 and 9 trailing behind the latest major.

i think theres a place for SDK upgrade skill somewhere as its pretty action oriented, but ill let you make the call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants