chore: Add config defaults #65
Open
+81
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a lot of region_name repitition, this sets defaults that match our configuration so that we can just remove those lines from the configuration.yaml entirely. Also fixes test_lint failing.
nikhars
reviewed
Dec 6, 2024
libsentrykube/config.py
Outdated
Comment on lines
71
to
90
| root = str(conf["root"]) if conf is not None and "root" in conf else "k8s" | ||
|
|
||
| cluster_def_root = ( | ||
| str(conf["cluster_def_root"]) | ||
| if conf is not None and "cluster_def_root" in conf | ||
| else f"clusters/{region_name}" | ||
| ) | ||
|
|
||
| cluster_name = ( | ||
| str(conf.get("cluster_name")) | ||
| if conf is not None and "cluster_name" in conf | ||
| else None | ||
| ) | ||
|
|
||
| materialized_manifests = ( | ||
| str(conf["materialized_manifests"]) | ||
| if conf is not None and "materialized_manifests" in conf | ||
| else f"materialized_manifests/{region_name}" | ||
| ) | ||
|
|
There was a problem hiding this comment.
There are a 4 instances of checks of conf is not None here. Wonder if it would be better to do the conf is None check once and set the required fields in that scenario. Then the other scenarios don't need that check and the code would be easier to comprehend.
There was a problem hiding this comment.
Ya I was on the fence of the clarity of this vs setting it twice.
nikhars
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a lot of region_name repetition, this sets defaults that match our configuration so that we can just remove those lines from the configuration.yaml entirely. This will allow us to completely remove the
k8sdictionary entirely from our config files.