chore: Bump volta to node 20 #15315
Merged
chore: Bump volta to node 20 #15315
+9
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chargome
commented
Feb 6, 2025
| @@ -199,6 +199,10 @@ export function extractType(ex: Error & { message: { error?: Error } }): string | |||
| export function extractMessage(ex: Error & { message: { error?: Error } }): string { | |||
| const message = ex?.message; | |||
|
|
|||
| if (isWebAssemblyException(ex)) { | |||
| return 'wasm exception'; | |||
There was a problem hiding this comment.
This failed on node versions > 18, also tested it in integration tests.
Decided to hardcode it, as opposed to ex.toString() which returns [object WebAssembly.Exception
size-limit report 📦
|
mydea
reviewed
Feb 6, 2025
| @@ -207,11 +211,6 @@ export function extractMessage(ex: Error & { message: { error?: Error } }): stri | |||
| return message.error.message; | |||
| } | |||
|
|
|||
| // Emscripten sets array[type, message] to the "message" property on the WebAssembly.Exception object | |||
| if (isWebAssemblyException(ex) && Array.isArray(ex.message) && ex.message.length == 2) { | |||
There was a problem hiding this comment.
should we leave this for legacy stuff? Not sure if/how relevant this is...
There was a problem hiding this comment.
hm yeah I updated it to fallback to 'wasm exception' now
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
mydea
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps our volta field to use Node 20, which will be required for building upcoming SDK versions (Nest@11, RR@7)