Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node): Set the correct fallback URL fields for outgoing https requests if they are not defined #15316

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

lforst
Copy link
Member

@lforst lforst commented Feb 5, 2025

#15233 introduced a change where we are actually using the return value of the vendored getRequestInfo() function to pass along to the original node:http(s) API calls.

We missed that OTEL does backfilling of certain fields (protocol and port) for HTTPS requests which we also need to do if we are actually passing along getRequestInfo(). It seems like node's default behavior when not providing a protocol/port as options object and using the https module is just to assume https: and 443.

Copy link
Contributor

github-actions bot commented Feb 5, 2025

size-limit report 📦

Path Size % Change Change
@sentry/browser 22.9 KB - -
@sentry/browser - with treeshaking flags 22.77 KB - -
@sentry/browser (incl. Tracing) 35.77 KB - -
@sentry/browser (incl. Tracing, Replay) 72.58 KB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 66.13 KB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 76.82 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 89.56 KB - -
@sentry/browser (incl. Feedback) 39.84 KB - -
@sentry/browser (incl. sendFeedback) 27.53 KB - -
@sentry/browser (incl. FeedbackAsync) 32.31 KB - -
@sentry/react 24.73 KB - -
@sentry/react (incl. Tracing) 37.67 KB - -
@sentry/vue 27.09 KB - -
@sentry/vue (incl. Tracing) 37.47 KB - -
@sentry/svelte 22.94 KB - -
CDN Bundle 24.2 KB - -
CDN Bundle (incl. Tracing) 35.92 KB - -
CDN Bundle (incl. Tracing, Replay) 70.56 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 75.7 KB - -
CDN Bundle - uncompressed 70.76 KB - -
CDN Bundle (incl. Tracing) - uncompressed 106.64 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 217.49 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 230.06 KB - -
@sentry/nextjs (client) 38.63 KB - -
@sentry/sveltekit (client) 36.2 KB - -
@sentry/node 156.58 KB +0.05% +72 B 🔺
@sentry/node - without tracing 97.58 KB +0.07% +61 B 🔺
@sentry/aws-serverless 107.07 KB +0.07% +74 B 🔺

View base workflow run

@lforst lforst marked this pull request as ready for review February 6, 2025 08:26
@lforst lforst requested a review from mydea February 6, 2025 08:26
Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing catch! Would be great to have a test that shows this, but we can look at this later too...

@lforst lforst merged commit fbedd59 into develop Feb 6, 2025
104 of 106 checks passed
@lforst lforst deleted the lforst-fix-https branch February 6, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants