fix(node): Set the correct fallback URL fields for outgoing https requests if they are not defined #15316
+15
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#15233 introduced a change where we are actually using the return value of the vendored
getRequestInfo()
function to pass along to the originalnode:http(s)
API calls.We missed that OTEL does backfilling of certain fields (protocol and port) for HTTPS requests which we also need to do if we are actually passing along
getRequestInfo()
. It seems like node's default behavior when not providing a protocol/port as options object and using thehttps
module is just to assumehttps:
and443
.