-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(replay): Add option to skip requestAnimationFrame
for canvas snapshots
#17380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
chargome
merged 6 commits into
develop
from
billy/feat-replay-canvas-snapshot-option-skip-raf
Aug 27, 2025
Merged
feat(replay): Add option to skip requestAnimationFrame
for canvas snapshots
#17380
chargome
merged 6 commits into
develop
from
billy/feat-replay-canvas-snapshot-option-skip-raf
Aug 27, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…napshots This adds an option to `snapshot()` to skip `requestAnimationFrame` when manually snapshotting.
e1ab481
to
69ee75e
Compare
size-limit report 📦
|
This was referenced Aug 14, 2025
chargome
approved these changes
Aug 26, 2025
chargome
added a commit
that referenced
this pull request
Aug 27, 2025
…snapshots (#17426) This is the v9 backport of #17380, which adds an option to `snapshot()` to skip `requestAnimationFrame` when manually snapshotting. --------- Co-authored-by: Charly Gomez <[email protected]>
This was referenced Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an option to
snapshot()
to skiprequestAnimationFrame
when manually snapshotting.Usage
Requires also bumping rrweb depending to support this option.
Closes #17330