-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(spans): track and report spans that were dropped #4005
feat(spans): track and report spans that were dropped #4005
Conversation
<!-- Describe your PR here --> --- Thank you for contributing to `sentry-python`! Please add tests to validate your changes, and lint your code using `tox -e linters`. Running the test suite on your PR might require maintainer approval. The AWS Lambda tests additionally require a maintainer to add a special label, and they will fail until this label is added.
Extend tests to check for correct `_meta` content. Cleanup.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #4005 +/- ##
==========================================
+ Coverage 80.15% 80.23% +0.07%
==========================================
Files 139 139
Lines 15403 15388 -15
Branches 2597 2597
==========================================
- Hits 12347 12346 -1
+ Misses 2211 2198 -13
+ Partials 845 844 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for simplifying! Overall looks good to me, but please address comments before merging
Oh yeah, and the |
Additional linter fixes
_SpanRecorder
now keeps track ofdropped_spans
, i.e. when abovemax_spans
.When spans were dropped, the
"spans"
property will be wrapped in anAnnotatedValue
, reporting the mutation.