Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(litestar): Add failed_request_status_codes #4021

Merged

Conversation

vrslev
Copy link
Contributor

@vrslev vrslev commented Feb 6, 2025

See #3134


Thank you for contributing to sentry-python! Please add tests to validate your changes, and lint your code using tox -e linters.

Running the test suite on your PR might require maintainer approval. The AWS Lambda tests additionally require a maintainer to add a special label, and they will fail until this label is added.

@vrslev vrslev changed the title Litestar-failed-request-status-codes feat(litestar): Add failed_request_status_codes Feb 6, 2025
@vrslev vrslev marked this pull request as ready for review February 6, 2025 14:34
@vrslev vrslev changed the title feat(litestar): Add failed_request_status_codes feat(litestar): Add failed_request_status_codes Feb 6, 2025
@sentrivana
Copy link
Contributor

Hey @vrslev, thank you for this PR! Code-wise looks great to me, I'll take it for a spin and prepare the docs for the change and then we should be ready to go. No action needed from your side, I'll ping you if that changes. Thanks again!

@vrslev
Copy link
Contributor Author

vrslev commented Feb 6, 2025

@sentrivana that's great! I've prepared docs myself already :)

getsentry/sentry-docs#12604

@sentrivana
Copy link
Contributor

Awesome!

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.23%. Comparing base (1fd2b86) to head (6fe635f).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4021      +/-   ##
==========================================
+ Coverage   80.21%   80.23%   +0.01%     
==========================================
  Files         139      139              
  Lines       15403    15411       +8     
  Branches     2601     2603       +2     
==========================================
+ Hits        12356    12365       +9     
- Misses       2203     2209       +6     
+ Partials      844      837       -7     
Files with missing lines Coverage Δ
sentry_sdk/integrations/litestar.py 84.66% <100.00%> (+0.86%) ⬆️

... and 6 files with indirect coverage changes

@sentrivana sentrivana merged commit bc72f78 into getsentry:master Feb 6, 2025
149 of 151 checks passed
@vrslev vrslev deleted the litestar-failed-request-status-codes branch February 6, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants