-
-
Notifications
You must be signed in to change notification settings - Fork 354
feat(replay): Add screenshotStrategy option for Android #5301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
4984ce3
851c466
54ba0e8
9c35c6c
a648626
24871bf
aef23db
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,6 +8,14 @@ import { enrichXhrBreadcrumbsForMobileReplay } from './xhrUtils'; | |
|
|
||
| export const MOBILE_REPLAY_INTEGRATION_NAME = 'MobileReplay'; | ||
|
|
||
| /** | ||
| * Screenshot strategy type for Android Session Replay. | ||
| * | ||
| * - `'canvas'`: Canvas-based screenshot strategy. This strategy does **not** support any masking options, it always masks text and images. Use this if your application has strict PII requirements. | ||
| * - `'pixelCopy'`: Pixel copy screenshot strategy (default). Supports all masking options. | ||
| */ | ||
| export type ScreenshotStrategy = 'canvas' | 'pixelCopy'; | ||
|
|
||
| export interface MobileReplayOptions { | ||
| /** | ||
| * Mask all text in recordings | ||
|
|
@@ -69,6 +77,19 @@ export interface MobileReplayOptions { | |
| * @default false | ||
| */ | ||
| enableFastViewRendering?: boolean; | ||
|
|
||
| /** | ||
| * Sets the screenshot strategy used by the Session Replay integration on Android. | ||
| * | ||
| * If your application has strict PII requirements we recommend using `'canvas'`. | ||
| * This strategy does **not** support any masking options, it always masks text and images. | ||
| * | ||
| * - Experiment: In case you are noticing issues with the canvas screenshot strategy, please report the issue on [GitHub](https://github.com/getsentry/sentry-java). | ||
| * | ||
| * @default 'pixelCopy' | ||
| * @platform android | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think that's a good idea 👍 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Opened an issue keep keep track of this. |
||
| */ | ||
| screenshotStrategy?: ScreenshotStrategy; | ||
| } | ||
|
|
||
| const defaultOptions: Required<MobileReplayOptions> = { | ||
|
|
@@ -78,6 +99,7 @@ const defaultOptions: Required<MobileReplayOptions> = { | |
| enableExperimentalViewRenderer: false, | ||
| enableViewRendererV2: true, | ||
| enableFastViewRendering: false, | ||
| screenshotStrategy: 'pixelCopy', | ||
lucas-zimerman marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| }; | ||
|
|
||
| function mergeOptions(initOptions: Partial<MobileReplayOptions>): Required<MobileReplayOptions> { | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.