chore(deps): update Cocoa SDK to v9.20.0#6409
Conversation
507d83f to
f774131
Compare
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
4e98712 to
4a42ca3
Compare
| } | ||
|
|
||
| sentry_cocoa_version = '9.19.1' | ||
| sentry_cocoa_version = '9.20.0' |
There was a problem hiding this comment.
Bug: The podspec references Sentry Cocoa SDK version 9.20.0, which is not available on CocoaPods. This will cause pod install to fail for default installations.
Severity: CRITICAL
Suggested Fix
Since version 9.20.0 is not on CocoaPods, either revert the version update in the podspec to a version that is available on CocoaPods, or update the logic to make SPM the default. Alternatively, update the CI and documentation to enforce setting SENTRY_USE_SPM=1 for this and future versions.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: packages/core/RNSentry.podspec#L57
Potential issue: The pull request updates the Sentry Cocoa SDK dependency to version
9.20.0 in `RNSentry.podspec`. However, this version was not published to CocoaPods, only
to Swift Package Manager (SPM). The podspec defaults to using CocoaPods unless the
`SENTRY_USE_SPM` environment variable is explicitly set to '1'. Consequently, any user
or CI/CD process (like the `native-tests.yml` workflow) running `pod install` without
this environment variable will encounter a build failure because the specified
dependency version cannot be resolved from the CocoaPods repository.
Did we get this right? 👍 / 👎 to inform future reviews.
There was a problem hiding this comment.
Adding the Blocked label since this is blocking till the xcframeworks work replacing the cocoapod dependency land.
Also added the ready-to-merge label to see how the failure reflects on the CI checks.
9a1cdcc to
abb3232
Compare
abb3232 to
cde5219
Compare
📲 Install BuildsAndroid
|
Bumps scripts/update-cocoa.sh from 9.19.1 to 9.20.0.
Auto-generated by a dependency updater.
Changelog
9.20.0
Important
This release contains an important fix for dropping too much data when the SDK gets rate limited. (#8324) This fix changes how rate limits are handled. Previously, if one data type (for example, user feedback) was rate limited, other data such as spans or sessions could also be dropped. Now, only the rate-limited data is dropped, while all other data continues to be sent. This may also reduce cases where unexpectedly large amounts of data appear to be dropped due to rate limiting.
Fixes
Features