feat: Improve Numbers and Units documentation #101544
Merged
+130
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's more appropriate there.
github-actions
bot
added
the
Scope: Frontend
natemoo-re
approved these changes
Oct 15, 2025
natemoo-re
added a commit
that referenced
this pull request
Oct 15, 2025
Although we already supported GitHub-flavored [Alert syntax](https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#alerts) in `.mdx` files, we weren't styling them properly. With this PR, we are now using the actual `Alert` component and passing through the correct props. cc @gggritso re: #101544
natemoo-re
deleted the
georgegritsouk/de-284-patterns-numbers-and-units
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This combines the work done in #99851 and by @ivy-sentry in Notion to move some documentation around. The text I added for "Data Visualization" is much better placed next to the text that Ivy composed for the not-yet-existing "Numbers and Units" section. In this PR I add a "Patterns" section to the Scraps sidebar, move the old Data Visualization docs to "Numbers and Units", and add the content from Notion so it's all in one place 🎉