Optimize event attachment cleanup query #101546
Draft
+28
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
OperationalError: canceling statement due to user requestduringsentry cleanupforEventAttachment.The root cause was the
BulkDeleteQuery's iterator attempting to fetch 10,000 records at a time from the massivesentry_eventattachmenttable, leading to database statement timeouts.This PR:
batch_sizeinBulkDeleteQuery.iterator()from 10,000 to 1,000.batch_sizeof 100 forEventAttachmentduring cleanup, as it's an exceptionally large table.batch_sizefunctionality.These changes ensure cleanup queries are less resource-intensive and complete within database timeouts, improving the reliability of data retention.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.