feat(grouping): Use project_root for in-app logic
#84156
Conversation
github-actions
bot
added
the
Scope: Backend
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
In the python SDK, we automatically mark frames whose filepath matches the project root as being in-app. As we are now moving to a world where all auto-in-app detection happens on the server, we need to replicate that logic in sentry.
The first step in this change is handled in getsentry/sentry-python#3941, which sends the
project_rootvalue used in the current SDK logic to the server indebug_meta. This is the second step: using that value on the server to set frames'in-appvalues. Once this is live, we can remove the corresponding logic from the SDK.Because we apply the server-side
in_applogic in two different places for a total of three times per event (once to set in-app values, and once each for the app and system variants to get hints), the easiest way to incorporate the new logic was to bundle it in with our other built-in stacktrace rules. That way, it gets applied all three times the others do.We don't currently have the ability to include variables in stacktrace rules the way we do in fingerprint rules, so this is done by manually constructing the rule text and merging it into the already-loaded config before any stacktrace rules are applied. It's not gated by platform, but since for now the Python SDK is the only one sending
debug_meta.project_root, it's effectively restricted to Python events.