✨ feat(activity notifications): create resolved in pr notif builder #84261
+153
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
JoshFerge
approved these changes
Jan 29, 2025
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #84261 +/- ##
========================================
Coverage 87.64% 87.64%
========================================
Files 9572 9576 +4
Lines 542375 542553 +178
Branches 21258 21258
========================================
+ Hits 475373 475543 +170
- Misses 66650 66658 +8
Partials 352 352 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently, if someone links a pr with a sentry issue so it the issue resolves when the pr is merged, they see
this is not correct. instead we should explain to the user that it will resolve because of a pr. i created a new notification builder for this. it will contain a link to the pr if the link exists which will make it more apparent what the activity is about.