Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: ensure unit is MetricUnit #84271

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ref: ensure unit is MetricUnit #84271

wants to merge 1 commit into from
+64 −36

Conversation

asottile-sentry
Copy link
Member

No description provided.

@asottile-sentry asottile-sentry requested a review from a team as a code owner January 29, 2025 21:45
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 29, 2025
asottile-sentry
asottile-sentry commented Jan 29, 2025
View reviewed changes
tests/sentry/snuba/metrics/test_naming_layer.py
Comment on lines -63 to 65
"dist:my_namespace/organizations/v1/my endpoint@{none}",
ParsedMRI("dist", "my_namespace", "organizations/v1/my endpoint", "{none}"),
),
(
"d:transactions/measurements.disk_io@byte/second",
ParsedMRI("d", "transactions", "measurements.disk_io", "byte/second"),
),
(
"c:custom/http.client.open_connections@{connection}",
ParsedMRI("c", "custom", "http.client.open_connections", "{connection}"),
),
(
"c:custom/http.client.active_requests@{request}",
ParsedMRI("c", "custom", "http.client.active_requests", "{request}"),
"dist:my_namespace/organizations/v1/my endpoint@none",
ParsedMRI("dist", "my_namespace", "organizations/v1/my endpoint", "none"),
),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these tests don't have valid units -- I "fixed" the {none} one and deleted the rest ?

@codecov Codecov
Copy link

codecov bot commented Jan 29, 2025 •
edited
Loading

❌ 38 Tests Failed:

Tests completed Failed Passed Skipped
23700 38 23662 293
View the top 3 failed tests by shortest run time 
tests.sentry.sentry_metrics.test_rh_metrics_multiprocess_steps::test_process_messages_invalid_messages[invalid_payload1-invalid_metric_name-True]
Stack Traces | 0.062s run time 
#x1B[1m#x1B[.../sentry/sentry_metrics/test_rh_metrics_multiprocess_steps.py#x1B[0m:458: in test_process_messages_invalid_messages
    assert error_text in caplog.text
#x1B[1m#x1B[31mE   AssertionError: assert 'invalid_metric_name' in 'ERROR    sentry.sentry_metrics.consumers.indexer.batch:batch.py:153 nonenonenonenonenonenonenonenonenonenonenonenonen...nonenonenonenonenonenonenonenonenonenonenonenonenonenonenonenonenonenonenonenonenonenonenonenonenonenonenonenonenone\n'#x1B[0m
#x1B[1m#x1B[31mE    +  where 'ERROR    sentry.sentry_metrics.consumers.indexer.batch:batch.py:153 nonenonenonenonenonenonenonenonenonenonenonenonen...nonenonenonenonenonenonenonenonenonenonenonenonenonenonenonenonenonenonenonenonenonenonenonenonenonenonenonenonenone\n' = <_pytest.logging.LogCaptureFixture object at 0x7f93e854ad50>.text#x1B[0m
tests.snuba.metrics.naming_layer.test_mri.TestMRIUtils::test_format_mri_field
Stack Traces | 0.097s run time 
#x1B[1m#x1B[.../metrics/naming_layer/test_mri.py#x1B[0m:16: in test_format_mri_field
    assert (
#x1B[1m#x1B[.../metrics/naming_layer/mri.py#x1B[0m:256: in format_mri_field
    parsed = parse_mri_field(field)
#x1B[1m#x1B[.../metrics/naming_layer/mri.py#x1B[0m:234: in parse_mri_field
    assert is_metric_unit(unit), unit
#x1B[1m#x1B[31mE   AssertionError: {request}#x1B[0m
tests.sentry.sentry_metrics.test_gen_metrics_multiprocess_steps::test_process_messages_invalid_messages[invalid_payload1-invalid_metric_name-True]
Stack Traces | 0.107s run time 
#x1B[1m#x1B[.../sentry/sentry_metrics/test_gen_metrics_multiprocess_steps.py#x1B[0m:527: in test_process_messages_invalid_messages
    assert error_text in caplog.text
#x1B[1m#x1B[31mE   AssertionError: assert 'invalid_metric_name' in 'ERROR    sentry.sentry_metrics.consumers.indexer.batch:batch.py:153 nonenonenonenonenonenonenonenonenonenonenonenonen...nonenonenonenonenonenonenonenonenonenonenonenonenonenonenonenonenonenonenonenonenonenonenonenonenonenonenonenonenone\n'#x1B[0m
#x1B[1m#x1B[31mE    +  where 'ERROR    sentry.sentry_metrics.consumers.indexer.batch:batch.py:153 nonenonenonenonenonenonenonenonenonenonenonenonen...nonenonenonenonenonenonenonenonenonenonenonenonenonenonenonenonenonenonenonenonenonenonenonenonenonenonenonenonenone\n' = <_pytest.logging.LogCaptureFixture object at 0x7f110805b6b0>.text#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@asottile-sentry asottile-sentry force-pushed the asottile-unit-is-metric-unit branch from 9fbda5a to 9db8260 Compare January 29, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@asottile-sentry