feat(aci): grid cell components for monitors #84281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
natemoo-re
reviewed
Jan 30, 2025
Member
natemoo-re
left a comment
natemoo-re
left a comment
There was a problem hiding this comment.
Shaping up well! Few small suggestions to tighten up the API surface
static/app/components/workflowEngine/gridCell/connectionCell.tsx
Outdated
Show resolved
Hide resolved
Bundle ReportChanges will increase total bundle size by 1.8kB (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: app-webpack-bundle-array-pushAssets Changed:
|
natemoo-re
approved these changes
Jan 31, 2025
| }, | ||
| ], | ||
| type: 'monitor', | ||
| renderText: count => tn('%s monitor', '%s monitors', count), |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Feb 5, 2025
# `TitleCell` refactored + renamed `AutomationTitleCell` so that it can be used for monitors and automations <img width="502" alt="Screenshot 2025-01-29 at 3 33 04 PM" src="https://github.com/user-attachments/assets/42dd80c5-6047-45cd-abe3-c1b48bd1856a" /> # `ConnectionCell` refactored + renamed `MonitorsCell` so that it can be used for connected monitors and automations <img width="278" alt="Screenshot 2025-01-29 at 3 32 49 PM" src="https://github.com/user-attachments/assets/e2146d8c-283f-4398-a944-fd06fb70aa37" /> # `IssueCell` https://github.com/user-attachments/assets/a17dabb0-e60f-4fe7-992e-c36bd16fb5b7 # `NumberCell` <img width="170" alt="Screenshot 2025-01-29 at 3 15 00 PM" src="https://github.com/user-attachments/assets/4fa44018-f2e6-402b-99af-aff4613138b5" /> --------- Co-authored-by: Nate Moore <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TitleCellrefactored + renamed
AutomationTitleCellso that it can be used for monitors and automationsConnectionCellrefactored + renamed
MonitorsCellso that it can be used for connected monitors and automationsIssueCellScreen.Recording.2025-01-29.at.3.15.26.PM.mov
NumberCell