chore(aci milestone 3): refactor migration helper tests

src/sentry/testutils/factories.py

@@ -42,6 +42,7 @@
     query_datasets_to_type,
 )
 from sentry.incidents.models.alert_rule import (
+    AlertRule,
     AlertRuleDetectionType,
     AlertRuleThresholdType,
     AlertRuleTriggerAction,
@@ -170,6 +171,8 @@
 from sentry.utils.performance_issues.performance_problem import PerformanceProblem
 from sentry.workflow_engine.models import (
     Action,
+    AlertRuleDetector,
+    AlertRuleWorkflow,
     DataCondition,
     DataConditionGroup,
     DataConditionGroupAction,
@@ -2215,3 +2218,29 @@ def create_data_condition_group_action(
         return DataConditionGroupAction.objects.create(
             action=action, condition_group=condition_group, **kwargs
         )
+
+    @staticmethod
+    @assume_test_silo_mode(SiloMode.REGION)
+    def create_alert_rule_detector(
+        alert_rule: AlertRule | None = None,
+        detector: Detector | None = None,
+        **kwargs,
+    ) -> AlertRuleDetector:
+        if alert_rule is None:
+            alert_rule = Factories.create_alert_rule()
+        if detector is None:
+            detector = Factories.create_detector()
+        return AlertRuleDetector.objects.create(alert_rule=alert_rule, detector=detector)
+
+    @staticmethod
+    @assume_test_silo_mode(SiloMode.REGION)
+    def create_alert_rule_workflow(
+        alert_rule: AlertRule | None = None,
+        workflow: Workflow | None = None,
+        **kwargs,
+    ) -> AlertRuleWorkflow:
+        if alert_rule is None:
+            alert_rule = Factories.create_alert_rule()
+        if workflow is None:
+            workflow = Factories.create_workflow()
+        return AlertRuleWorkflow.objects.create(alert_rule=alert_rule, workflow=workflow)

src/sentry/testutils/fixtures.py

@@ -660,6 +660,12 @@ def create_detector_workflow(self, *args, **kwargs):
     def create_workflow_data_condition_group(self, *args, **kwargs):
         return Factories.create_workflow_data_condition_group(*args, **kwargs)
 
+    def create_alert_rule_detector(self, *args, **kwargs):
+        return Factories.create_alert_rule_detector(*args, **kwargs)
+
+    def create_alert_rule_workflow(self, *args, **kwargs):
+        return Factories.create_alert_rule_workflow(*args, **kwargs)
+
     # workflow_engine.models.action
     def create_action(self, *args, **kwargs):
         return Factories.create_action(*args, **kwargs)

src/sentry/workflow_engine/migration_helpers/alert_rule.py

@@ -431,7 +431,7 @@ def migrate_alert_rule(
     )
 
 
-def update_migrated_alert_rule(alert_rule: AlertRule, updated_fields: dict[str, Any]) -> (
+def dual_update_migrated_alert_rule(alert_rule: AlertRule, updated_fields: dict[str, Any]) -> (
     tuple[
         DetectorState,
         Detector,