Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(widget-builder): Remove circular dependency in analytics #84289

Merged
merged 1 commit into from
Jan 30, 2025
+3 −3
Merged

test(widget-builder): Remove circular dependency in analytics #84289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion static/app/utils/analytics/dashboardsAnalyticsEvents.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type {DashboardsLayout} from 'sentry/views/dashboards/manage';
import type {DashboardsLayout} from 'sentry/views/dashboards/manage/types';

export enum WidgetBuilderVersion {
PAGE = 'page',
Expand Down
3 changes: 1 addition & 2 deletions static/app/views/dashboards/manage/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ import {useNavigate} from 'sentry/utils/useNavigate';
import useOrganization from 'sentry/utils/useOrganization';
import {DashboardImportButton} from 'sentry/views/dashboards/manage/dashboardImport';
import DashboardTable from 'sentry/views/dashboards/manage/dashboardTable';
import type {DashboardsLayout} from 'sentry/views/dashboards/manage/types';
import {MetricsRemovedAlertsWidgetsAlert} from 'sentry/views/metrics/metricsRemovedAlertsWidgetsAlert';
import RouteError from 'sentry/views/routeError';

Expand Down Expand Up @@ -73,8 +74,6 @@ export const LAYOUT_KEY = 'dashboards-overview-layout';
const GRID = 'grid';
const TABLE = 'table';

export type DashboardsLayout = 'grid' | 'table';

function shouldShowTemplates(): boolean {
const shouldShow = localStorage.getItem(SHOW_TEMPLATES_KEY);
return shouldShow === 'true' || shouldShow === null;
Expand Down
1 change: 1 addition & 0 deletions static/app/views/dashboards/manage/types.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export type DashboardsLayout = 'grid' | 'table';
Loading