ref(tags): add concurrent_limit to ratelimit #94831
Open
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've seen some load increases on the errors cluster that I think might have been partially driven by specific users (those users being proxy users of internal integrations) hitting endpoints that run expensive/long queries on clickhouse
We have some rate-limiting in snuba but that is on the project and organization level for the most part. When debugging on sentry it looked like default
concurrent_limitis 25deprecated rate limit specification {'GET': {<RateLimitCategory.IP: 'ip'>: RateLimit(limit=10, window=1, concurrent_limit=25), <RateLimitCategory.USER: 'user'>: RateLimit(limit=10, window=1, concurrent_limit=25), <RateLimitCategory.ORGANIZATION: 'org'>: RateLimit(limit=40, window=1, concurrent_limit=25)}}(from SENTRY-3PFR)
For these endpoints we will want lower than 25 per user since the snuba concurrent ratelimiting is lower than 25 for this referrer