feat: add test-suite dropdown #94838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ajay-sentry
reviewed
Jul 7, 2025
| // Otherwise show only 1 test suite. | ||
| const totalLength = | ||
| (value[0]?.length ?? 0) + (value[1]?.length ?? 0) + (value[1] ? 2 : 0); | ||
| const suitesToShow = totalLength < 22 ? value.slice(0, 2) : value.slice(0, 1); |
There was a problem hiding this comment.
nit: should we set 22 here and on line 76 to a const? Like MAX_SUITE_UI_LENGTH or smth
There was a problem hiding this comment.
yep yep good catch
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jul 14, 2025
This PR adds the test suite dropdown to the Test Analytics page. Notes - - Adds the `TestSuiteDropdown` component - Adds that component to the tests page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the test suite dropdown to the Test Analytics page.
Notes
TestSuiteDropdowncomponent