fix(taskworker) Add metric to see how long we wait #94864
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm interested in understanding how much time we're losing to waiting on empty multiprocessing queues. This metric will help understand this, so we can tune workers more.
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #94864 +/- ##
========================================
Coverage 87.89% 87.89%
========================================
Files 10440 10442 +2
Lines 603678 604023 +345
Branches 23505 23505
========================================
+ Hits 530577 530902 +325
- Misses 72734 72754 +20
Partials 367 367 |
evanh
approved these changes
Jul 3, 2025
src/sentry/taskworker/workerchild.py
Outdated
| try: | ||
| # If the queue is empty, this could block for a second. | ||
| # We could be losing a bunch of throughput here. |
There was a problem hiding this comment.
I don't think this is accurate. If this blocks, it means there's no work to be done anyways. E.g. the throughput can't be "lost" here. Pausing here isn't causing the worker to not do work.
There was a problem hiding this comment.
Fair point. I'll trim that out. I'm interested to see if making this timeout shorter, and adjusting worker buffer sizes could help us get more throughput from workers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm interested in understanding how much time we're losing to waiting on empty multiprocessing queues. This metric will help understand this, so we can tune workers more.