feat: Snapshot SnubaQueryEventTypes when updating alert rule #94879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #94879 +/- ##
==========================================
+ Coverage 79.45% 87.89% +8.44%
==========================================
Files 10444 10446 +2
Lines 604023 604076 +53
Branches 23517 23517
==========================================
+ Hits 479898 530961 +51063
+ Misses 123762 72752 -51010
Partials 363 363 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the EventsAnalyticsPlatform dataset, we use EventType to disambiguate
between trace item type logs vs spans. I'd like to return event type as a part
of the incident response since, it's used to determine the copy on the incident
history table.
Saving a snapshot of SnubaQueryEventType so that the correct event types
are returned if the alert was updated.