ref(auto_config): Use factory to create the right instance #94880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's two ways of creating a frame info, thus, using two different classes to do so.
github-actions
bot
added
the
Scope: Backend
armenzg
commented
Jul 3, 2025
| def __init__(self, frame: Mapping[str, Any], platform: str | None = None) -> None: | ||
| if platform: | ||
| platform_config = PlatformConfig(platform) | ||
| if platform_config.extracts_filename_from_module(): |
There was a problem hiding this comment.
This removed block is what would make the frame info be determined based on the filename and module.
frame_info_from_module will now only belong to ModuleBasedFrameInfo.
| def create_frame_info(frame: Mapping[str, Any], platform: str | None = None) -> FrameInfo: | ||
| """Factory function to create the appropriate FrameInfo instance.""" | ||
| frame_info: FrameInfo | None = None | ||
| if platform: |
There was a problem hiding this comment.
Ideally, we would always pass platform, however, it's not important to fix.
| @@ -69,23 +111,6 @@ def transformations(self, frame_file_path: str) -> str: | |||
|
|
|||
| return frame_file_path | |||
|
|
|||
| def frame_info_from_module(self, frame: Mapping[str, Any]) -> None: | |||
There was a problem hiding this comment.
Moved to ModuleBasedFrameInfo.
| else: | ||
| raise MissingModuleOrAbsPath("Investigate why the data is missing.") | ||
|
|
||
| def __repr__(self) -> str: |
There was a problem hiding this comment.
These two have been moved to the base class.
| @@ -22,7 +22,7 @@ | |||
| UnexpectedPathException, | |||
| UnsupportedFrameInfo, | |||
| ) | |||
| from sentry.issues.auto_source_code_config.frame_info import FrameInfo | |||
| from sentry.issues.auto_source_code_config.frame_info import create_frame_info | |||
There was a problem hiding this comment.
This test module only changes from FrameInfo to create_frame_info.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's two ways of creating frame info instances, thus, decoupling into two different classes.