feat(replay): add time duration for each playback speed #94888
+36
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: jasmin.kassas <[email protected]>
Co-authored-by: jasmin.kassas <[email protected]>
github-actions
bot
added
the
Scope: Frontend
jas-kas
changed the title
Co-authored-by: jasmin.kassas <[email protected]>
Co-authored-by: jasmin.kassas <[email protected]>
Co-authored-by: jasmin.kassas <[email protected]>
Co-authored-by: jasmin.kassas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes a detailed plan to enhance the Replay Details page by displaying the adjusted replay duration next to each playback speed option.
Why:
To provide users with immediate insight into the actual duration of a replay when viewed at different playback speeds, improving clarity and user experience.
What:
The plan outlines modifications to
ReplayPreferenceDropdown.tsxto calculate and display the adjusted replay duration (e.g., "2x (10:00)"). It ensures the duration is only shown when replay data is fully loaded and available, gracefully falling back to the current display otherwise.