Skip to content

ref(ui): Replace DropdownAutoComplete use in team selector #98067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 25, 2025
Merged

ref(ui): Replace DropdownAutoComplete use in team selector #98067

merged 1 commit into from
Aug 25, 2025

Conversation

evanpurkhiser
Copy link
Member

No description provided.

@evanpurkhiser evanpurkhiser requested a review from a team August 20, 2025 18:38
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Aug 20, 2025
cursor[bot]

This comment was marked as outdated.

Sign in to view

@codecov Codecov
Copy link

codecov bot commented Aug 20, 2025 •
edited
Loading

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
11440 2 11438 10
View the top 2 failed test(s) by shortest run time 
ProjectTeams can associate a team with project
Stack Traces | 0.117s run time 
TestingLibraryElementError: Unable to find an element with the text: #team-slug-2. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
...
    at Object.getElementError (.../sentry/node_modules/.pnpm/@[email protected]/node_modules/@.../dom/dist/config.js:37:19)
    at .../sentry/node_modules/.pnpm/@[email protected]/node_modules/@.../dom/dist/query-helpers.js:76:38
    at .../sentry/node_modules/.pnpm/@[email protected]/node_modules/@.../dom/dist/query-helpers.js:52:17
    at .../sentry/node_modules/.pnpm/@[email protected]/node_modules/@.../dom/dist/query-helpers.js:95:19
    at Object.getByText (.../settings/project/projectTeams.spec.tsx:252:34)
ProjectTeams creates a new team adds it to current project using the "create team modal" in dropdown
Stack Traces | 0.132s run time 
TestingLibraryElementError: Unable to find an accessible element with the role "link" and name "Create Team"

Here are the accessible roles:

  heading:

  Name "Project Teams for project-slug":
  ...

  --------------------------------------------------
  button:

  Name "Add Team":
  ...

  Name "Create Team":
  ...

  Name "Remove":
  ...

  --------------------------------------------------
  presentation:

  Name "":
  ...

  Name "":
  ...

  --------------------------------------------------
  img:

  Name "":
  ...

  Name "":
  ...

  --------------------------------------------------
  textbox:

  Name "":
  ...

  --------------------------------------------------
  separator:

  Name "":
  ...

  --------------------------------------------------
  listbox:

  Name "Add Team":
  ...

  --------------------------------------------------
  paragraph:

  Name "":
  ...

  --------------------------------------------------
  link:

  Name "TS #team-slug":
  ...

  --------------------------------------------------

Ignored nodes: comments, script, style
...
    at Object.getElementError (.../sentry/node_modules/.pnpm/@[email protected]/node_modules/@.../dom/dist/config.js:37:19)
    at .../sentry/node_modules/.pnpm/@[email protected]/node_modules/@.../dom/dist/query-helpers.js:76:38
    at .../sentry/node_modules/.pnpm/@[email protected]/node_modules/@.../dom/dist/query-helpers.js:52:17
    at .../sentry/node_modules/.pnpm/@[email protected]/node_modules/@.../dom/dist/query-helpers.js:95:19
    at Object.getByRole (.../settings/project/projectTeams.spec.tsx:291:34)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/ref-ui-replace-dropdownautocomplete-use-in-team-selector branch from e7db2b5 to a7c97e8 Compare August 20, 2025 22:54
gggritso
gggritso approved these changes Aug 25, 2025
View reviewed changes
static/app/views/settings/components/teamSelect/utils.tsx
menuWidth={300}
options={dropdownItems}
value=""
disabled={false}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh, dang! That's kind of surprising for CompactSelect to disable header trailing items like this 🤔

@evanpurkhiser evanpurkhiser merged commit d3edfa7 into master Aug 25, 2025
45 checks passed
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/ref-ui-replace-dropdownautocomplete-use-in-team-selector branch August 25, 2025 15:29
lzhao-sentry pushed a commit that referenced this pull request Aug 25, 2025
@evanpurkhiser @lzhao-sentry
ref(ui): Replace DropdownAutoComplete use in team selector (#98067)
6cc33b6
andrewshie-sentry pushed a commit that referenced this pull request Aug 26, 2025
@evanpurkhiser @andrewshie-sentry
ref(ui): Replace DropdownAutoComplete use in team selector (#98067)
4c66630
constantinius pushed a commit that referenced this pull request Sep 1, 2025
@evanpurkhiser @constantinius
ref(ui): Replace DropdownAutoComplete use in team selector (#98067)
9e9c917
@github-actions github-actions bot locked and limited conversation to collaborators Sep 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@gggritso gggritso gggritso approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evanpurkhiser @gggritso