Skip to content

Conversation

evanpurkhiser
Copy link
Member

@evanpurkhiser evanpurkhiser commented Aug 20, 2025

The dropdowns are replaced with the CompactSelect component.

There are a couple hacks in here necessary to make hover activation a
good experience. In the future we'll probably want to refactor this
along with our compact select component to natively support some type of
accessible hover activation.

See it in action here https://sentry-nqi0z0e0z.sentry.dev/settings/organization/

@evanpurkhiser evanpurkhiser requested a review from a team August 20, 2025 22:25
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Aug 20, 2025
cursor[bot]

This comment was marked as outdated.

@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/ref-ui-remove-dropdownautocompletemenu-from-settings-breadcrumbs branch from b08e2fb to b9b4194 Compare August 20, 2025 22:29
Copy link

codecov bot commented Aug 20, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
11441 1 11440 10
View the top 1 failed test(s) by shortest run time
Breadcrumbs renders a crumb dropdown
Stack Traces | 1.06s run time
Error: Unable to find an element with the text: item3. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
...
    at waitForWrapper (.../sentry/node_modules/.pnpm/@[email protected]/node_modules/@.../dom/dist/wait-for.js:163:27)
    at .../sentry/node_modules/.pnpm/@[email protected]/node_modules/@.../dom/dist/query-helpers.js:86:33
    at Object.findByText (.../app/components/breadcrumbs.spec.tsx:96:32)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

The dropdowns are replaced with the CompactSelect component.

There are a couple hacks in here necessary to make hover activation a
good experience. In the future we'll probably want to refactor this
along with our compact select component to natively support some type of
accessible hover activation.
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/ref-ui-remove-dropdownautocompletemenu-from-settings-breadcrumbs branch from b9b4194 to 191b891 Compare August 25, 2025 16:36
@evanpurkhiser evanpurkhiser merged commit 5fe623b into master Aug 25, 2025
46 checks passed
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/ref-ui-remove-dropdownautocompletemenu-from-settings-breadcrumbs branch August 25, 2025 16:56
Copy link

sentry-io bot commented Aug 25, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

Did you find this useful? React with a 👍 or 👎

andrewshie-sentry pushed a commit that referenced this pull request Aug 26, 2025
…98078)

The dropdowns are replaced with the CompactSelect component.

There are a couple hacks in here necessary to make hover activation a
good experience. In the future we'll probably want to refactor this
along with our compact select component to natively support some type of
accessible hover activation.

See it in action here
https://sentry-nqi0z0e0z.sentry.dev/settings/organization/
constantinius pushed a commit that referenced this pull request Sep 1, 2025
…98078)

The dropdowns are replaced with the CompactSelect component.

There are a couple hacks in here necessary to make hover activation a
good experience. In the future we'll probably want to refactor this
along with our compact select component to natively support some type of
accessible hover activation.

See it in action here
https://sentry-nqi0z0e0z.sentry.dev/settings/organization/
@github-actions github-actions bot locked and limited conversation to collaborators Sep 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants