Skip to content

🔧 chore(aci): make ACI dual write True by default #98084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

🔧 chore(aci): make ACI dual write True by default #98084

wants to merge 1 commit into from

Conversation

iamrajjoshi
Copy link
Member

we have passed the dual-write face of ACI and are working on processing.

we should set the default for these flags to be True, so when folks are developing locally, we start automatically creating these models and don't need to enable these GA'ed flags

@iamrajjoshi iamrajjoshi requested a review from a team August 20, 2025 23:23
@iamrajjoshi iamrajjoshi self-assigned this Aug 20, 2025
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 20, 2025
@codecov Codecov
Copy link

codecov bot commented Aug 20, 2025 •
edited
Loading

❌ 1822 Tests Failed:

Tests completed Failed Passed Skipped
27197 1822 25375 612
View the top 3 failed test(s) by shortest run time 
tests.sentry.workflow_engine.processors.test_workflow.TestDeleteWorkflow::test_delete_workflow__no_actions
Stack Traces | 0.621s run time 
#x1B[1m#x1B[.../workflow_engine/processors/test_workflow.py#x1B[0m:962: in setUp
    self.project = Factories.create_project(organization=self.organization)
#x1B[1m#x1B[.../hostedtoolcache/Python/3.13.1.../x64/lib/python3.13/contextlib.py#x1B[0m:85: in inner
    return func(*args, **kwds)
#x1B[1m#x1B[.../sentry/testutils/factories.py#x1B[0m:552: in create_project
    project = Project.objects.create(organization=organization, **kwargs)
#x1B[1m#x1B[.../sentry/silo/base.py#x1B[0m:158: in override
    return original_method(*args, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../db/models/manager.py#x1B[0m:87: in manager_method
    return getattr(self.get_queryset(), name)(*args, **kwargs)
#x1B[1m#x1B[.../sentry/silo/base.py#x1B[0m:158: in override
    return original_method(*args, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../db/models/query.py#x1B[0m:663: in create
    obj.save(force_insert=True, using=self.db)
#x1B[1m#x1B[.../sentry/silo/base.py#x1B[0m:158: in override
    return original_method(*args, **kwargs)
#x1B[1m#x1B[.../sentry/models/project.py#x1B[0m:413: in save
    self._save_project(*args, **kwargs)
#x1B[1m#x1B[.../sentry/models/project.py#x1B[0m:388: in _save_project
    save_with_snowflake_id(
#x1B[1m#x1B[.../sentry/utils/snowflake.py#x1B[0m:59: in save_with_snowflake_id
    save_callback()
#x1B[1m#x1B[.../sentry/models/project.py#x1B[0m:391: in <lambda>
    save_callback=lambda: super(Project, self).save(*args, **kwargs),
#x1B[1m#x1B[31m.venv/lib/python3.13.../db/models/base.py#x1B[0m:902: in save
    self.save_base(
#x1B[1m#x1B[.../sentry/silo/base.py#x1B[0m:158: in override
    return original_method(*args, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../db/models/base.py#x1B[0m:1023: in save_base
    post_save.send(
#x1B[1m#x1B[.../testutils/pytest/stale_database_reads.py#x1B[0m:100: in send
    return old_send(self, sender, **named)
#x1B[1m#x1B[31m.venv/lib/python3.13.../django/dispatch/dispatcher.py#x1B[0m:189: in send
    response = receiver(signal=self, sender=sender, **named)
#x1B[1m#x1B[.../sentry/receivers/project_detectors.py#x1B[0m:22: in create_project_detectors
    Detector.objects.create(
#x1B[1m#x1B[.../sentry/silo/base.py#x1B[0m:158: in override
    return original_method(*args, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../db/models/manager.py#x1B[0m:87: in manager_method
    return getattr(self.get_queryset(), name)(*args, **kwargs)
#x1B[1m#x1B[.../sentry/silo/base.py#x1B[0m:158: in override
    return original_method(*args, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../db/models/query.py#x1B[0m:663: in create
    obj.save(force_insert=True, using=self.db)
#x1B[1m#x1B[.../sentry/silo/base.py#x1B[0m:158: in override
    return original_method(*args, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../db/models/base.py#x1B[0m:902: in save
    self.save_base(
#x1B[1m#x1B[.../sentry/silo/base.py#x1B[0m:158: in override
    return original_method(*args, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../db/models/base.py#x1B[0m:988: in save_base
    pre_save.send(
#x1B[1m#x1B[.../testutils/pytest/stale_database_reads.py#x1B[0m:100: in send
    return old_send(self, sender, **named)
#x1B[1m#x1B[31m.venv/lib/python3.13.../django/dispatch/dispatcher.py#x1B[0m:189: in send
    response = receiver(signal=self, sender=sender, **named)
#x1B[1m#x1B[.../workflow_engine/models/detector.py#x1B[0m:159: in enforce_config_schema
    group_type = instance.group_type
#x1B[1m#x1B[.../workflow_engine/models/detector.py#x1B[0m:94: in group_type
    raise ValueError(f"Group type {self.type} not registered")
#x1B[1m#x1B[31mE   ValueError: Group type error not registered#x1B[0m
tests.sentry.workflow_engine.processors.test_workflow.TestDeleteWorkflow::test_delete_workflow[action_filter]
Stack Traces | 0.622s run time 
#x1B[1m#x1B[.../workflow_engine/processors/test_workflow.py#x1B[0m:962: in setUp
    self.project = Factories.create_project(organization=self.organization)
#x1B[1m#x1B[.../hostedtoolcache/Python/3.13.1.../x64/lib/python3.13/contextlib.py#x1B[0m:85: in inner
    return func(*args, **kwds)
#x1B[1m#x1B[.../sentry/testutils/factories.py#x1B[0m:552: in create_project
    project = Project.objects.create(organization=organization, **kwargs)
#x1B[1m#x1B[.../sentry/silo/base.py#x1B[0m:158: in override
    return original_method(*args, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../db/models/manager.py#x1B[0m:87: in manager_method
    return getattr(self.get_queryset(), name)(*args, **kwargs)
#x1B[1m#x1B[.../sentry/silo/base.py#x1B[0m:158: in override
    return original_method(*args, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../db/models/query.py#x1B[0m:663: in create
    obj.save(force_insert=True, using=self.db)
#x1B[1m#x1B[.../sentry/silo/base.py#x1B[0m:158: in override
    return original_method(*args, **kwargs)
#x1B[1m#x1B[.../sentry/models/project.py#x1B[0m:413: in save
    self._save_project(*args, **kwargs)
#x1B[1m#x1B[.../sentry/models/project.py#x1B[0m:388: in _save_project
    save_with_snowflake_id(
#x1B[1m#x1B[.../sentry/utils/snowflake.py#x1B[0m:59: in save_with_snowflake_id
    save_callback()
#x1B[1m#x1B[.../sentry/models/project.py#x1B[0m:391: in <lambda>
    save_callback=lambda: super(Project, self).save(*args, **kwargs),
#x1B[1m#x1B[31m.venv/lib/python3.13.../db/models/base.py#x1B[0m:902: in save
    self.save_base(
#x1B[1m#x1B[.../sentry/silo/base.py#x1B[0m:158: in override
    return original_method(*args, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../db/models/base.py#x1B[0m:1023: in save_base
    post_save.send(
#x1B[1m#x1B[.../testutils/pytest/stale_database_reads.py#x1B[0m:100: in send
    return old_send(self, sender, **named)
#x1B[1m#x1B[31m.venv/lib/python3.13.../django/dispatch/dispatcher.py#x1B[0m:189: in send
    response = receiver(signal=self, sender=sender, **named)
#x1B[1m#x1B[.../sentry/receivers/project_detectors.py#x1B[0m:22: in create_project_detectors
    Detector.objects.create(
#x1B[1m#x1B[.../sentry/silo/base.py#x1B[0m:158: in override
    return original_method(*args, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../db/models/manager.py#x1B[0m:87: in manager_method
    return getattr(self.get_queryset(), name)(*args, **kwargs)
#x1B[1m#x1B[.../sentry/silo/base.py#x1B[0m:158: in override
    return original_method(*args, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../db/models/query.py#x1B[0m:663: in create
    obj.save(force_insert=True, using=self.db)
#x1B[1m#x1B[.../sentry/silo/base.py#x1B[0m:158: in override
    return original_method(*args, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../db/models/base.py#x1B[0m:902: in save
    self.save_base(
#x1B[1m#x1B[.../sentry/silo/base.py#x1B[0m:158: in override
    return original_method(*args, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../db/models/base.py#x1B[0m:988: in save_base
    pre_save.send(
#x1B[1m#x1B[.../testutils/pytest/stale_database_reads.py#x1B[0m:100: in send
    return old_send(self, sender, **named)
#x1B[1m#x1B[31m.venv/lib/python3.13.../django/dispatch/dispatcher.py#x1B[0m:189: in send
    response = receiver(signal=self, sender=sender, **named)
#x1B[1m#x1B[.../workflow_engine/models/detector.py#x1B[0m:159: in enforce_config_schema
    group_type = instance.group_type
#x1B[1m#x1B[.../workflow_engine/models/detector.py#x1B[0m:94: in group_type
    raise ValueError(f"Group type {self.type} not registered")
#x1B[1m#x1B[31mE   ValueError: Group type error not registered#x1B[0m
tests.sentry.workflow_engine.processors.test_workflow.TestDeleteWorkflow::test_delete_workflow[action_condition]
Stack Traces | 0.649s run time 
#x1B[1m#x1B[.../workflow_engine/processors/test_workflow.py#x1B[0m:962: in setUp
    self.project = Factories.create_project(organization=self.organization)
#x1B[1m#x1B[.../hostedtoolcache/Python/3.13.1.../x64/lib/python3.13/contextlib.py#x1B[0m:85: in inner
    return func(*args, **kwds)
#x1B[1m#x1B[.../sentry/testutils/factories.py#x1B[0m:552: in create_project
    project = Project.objects.create(organization=organization, **kwargs)
#x1B[1m#x1B[.../sentry/silo/base.py#x1B[0m:158: in override
    return original_method(*args, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../db/models/manager.py#x1B[0m:87: in manager_method
    return getattr(self.get_queryset(), name)(*args, **kwargs)
#x1B[1m#x1B[.../sentry/silo/base.py#x1B[0m:158: in override
    return original_method(*args, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../db/models/query.py#x1B[0m:663: in create
    obj.save(force_insert=True, using=self.db)
#x1B[1m#x1B[.../sentry/silo/base.py#x1B[0m:158: in override
    return original_method(*args, **kwargs)
#x1B[1m#x1B[.../sentry/models/project.py#x1B[0m:413: in save
    self._save_project(*args, **kwargs)
#x1B[1m#x1B[.../sentry/models/project.py#x1B[0m:388: in _save_project
    save_with_snowflake_id(
#x1B[1m#x1B[.../sentry/utils/snowflake.py#x1B[0m:59: in save_with_snowflake_id
    save_callback()
#x1B[1m#x1B[.../sentry/models/project.py#x1B[0m:391: in <lambda>
    save_callback=lambda: super(Project, self).save(*args, **kwargs),
#x1B[1m#x1B[31m.venv/lib/python3.13.../db/models/base.py#x1B[0m:902: in save
    self.save_base(
#x1B[1m#x1B[.../sentry/silo/base.py#x1B[0m:158: in override
    return original_method(*args, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../db/models/base.py#x1B[0m:1023: in save_base
    post_save.send(
#x1B[1m#x1B[.../testutils/pytest/stale_database_reads.py#x1B[0m:100: in send
    return old_send(self, sender, **named)
#x1B[1m#x1B[31m.venv/lib/python3.13.../django/dispatch/dispatcher.py#x1B[0m:189: in send
    response = receiver(signal=self, sender=sender, **named)
#x1B[1m#x1B[.../sentry/receivers/project_detectors.py#x1B[0m:22: in create_project_detectors
    Detector.objects.create(
#x1B[1m#x1B[.../sentry/silo/base.py#x1B[0m:158: in override
    return original_method(*args, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../db/models/manager.py#x1B[0m:87: in manager_method
    return getattr(self.get_queryset(), name)(*args, **kwargs)
#x1B[1m#x1B[.../sentry/silo/base.py#x1B[0m:158: in override
    return original_method(*args, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../db/models/query.py#x1B[0m:663: in create
    obj.save(force_insert=True, using=self.db)
#x1B[1m#x1B[.../sentry/silo/base.py#x1B[0m:158: in override
    return original_method(*args, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../db/models/base.py#x1B[0m:902: in save
    self.save_base(
#x1B[1m#x1B[.../sentry/silo/base.py#x1B[0m:158: in override
    return original_method(*args, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../db/models/base.py#x1B[0m:988: in save_base
    pre_save.send(
#x1B[1m#x1B[.../testutils/pytest/stale_database_reads.py#x1B[0m:100: in send
    return old_send(self, sender, **named)
#x1B[1m#x1B[31m.venv/lib/python3.13.../django/dispatch/dispatcher.py#x1B[0m:189: in send
    response = receiver(signal=self, sender=sender, **named)
#x1B[1m#x1B[.../workflow_engine/models/detector.py#x1B[0m:159: in enforce_config_schema
    group_type = instance.group_type
#x1B[1m#x1B[.../workflow_engine/models/detector.py#x1B[0m:94: in group_type
    raise ValueError(f"Group type {self.type} not registered")
#x1B[1m#x1B[31mE   ValueError: Group type error not registered#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ameliahsu ameliahsu ameliahsu approved these changes

Assignees

@iamrajjoshi iamrajjoshi

Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iamrajjoshi @ameliahsu