Skip to content

Conversation

evanpurkhiser
Copy link
Member

No description provided.

@evanpurkhiser evanpurkhiser requested a review from a team August 21, 2025 17:37
@evanpurkhiser evanpurkhiser changed the title ref(ts): Remove dropdownAutoComplete usage in timeRangeSelector ref(js): Remove dropdownAutoComplete usage in timeRangeSelector Aug 21, 2025
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Aug 21, 2025
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/ref-ts-remove-dropdownautocomplete-usage-in-timerangeselector branch from 06099ea to 157d15f Compare August 21, 2025 18:04
@evanpurkhiser evanpurkhiser requested a review from a team as a code owner August 21, 2025 18:04
Copy link
Member

@gggritso gggritso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 is this to avoid calling the awkwardly-named onClick prop in TimeRangeSelector?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah the naming here was weird

@evanpurkhiser evanpurkhiser enabled auto-merge (squash) August 25, 2025 15:30
@evanpurkhiser evanpurkhiser merged commit f162189 into master Aug 25, 2025
45 of 46 checks passed
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/ref-ts-remove-dropdownautocomplete-usage-in-timerangeselector branch August 25, 2025 15:41
lzhao-sentry pushed a commit that referenced this pull request Aug 25, 2025
andrewshie-sentry pushed a commit that referenced this pull request Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants