Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using offset for oldest completed record in upkeep #137

Closed
markstory opened this issue Jan 27, 2025 · 0 comments · Fixed by #143
Closed

Stop using offset for oldest completed record in upkeep #137

markstory opened this issue Jan 27, 2025 · 0 comments · Fixed by #143
Assignees
@enochtangg

Comments

@markstory
Copy link
Member

We currently are using MAX(offset) to identify the oldest completed activation. Instead we should use added_at to identify the oldest record as added_at doesn't behave inconsistently across partitions and rebalances.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@enochtangg enochtangg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(taskbroker): Use earliest task instead of oldest for handling removals getsentry/taskbroker
2 participants
@markstory @enochtangg