Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(taskbroker): Use earliest task instead of oldest for handling removals #143

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

enochtangg
Copy link
Member

Instead of using max(offset) to determine which tasks to expire and complete, use max(added_at) instead. This ensures that we don't have inconsistency as tasks of multiple partitions can live on the same sqlite.

Fixes: #137

@enochtangg enochtangg requested a review from a team as a code owner January 29, 2025 20:01
@enochtangg enochtangg merged commit 03e92be into main Jan 30, 2025
11 checks passed
@enochtangg enochtangg deleted the use-added-at-in-upkeep branch January 30, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop using offset for oldest completed record in upkeep
2 participants