fix(uptime): fix trace header format #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaprl
approved these changes
Feb 6, 2025
| @@ -173,10 +173,13 @@ fn make_trace_header(config: &CheckConfig, trace_id: &Uuid, span_id: SpanId) -> | |||
| // according to the service's sampling policy. see | |||
| // https://develop.sentry.dev/sdk/telemetry/traces/#header-sentry-trace | |||
| // for more information. | |||
|
|
|||
| let trace_id_without_dashes = trace_id.to_string().replace("-", ""); | |||
There was a problem hiding this comment.
I think the better way to do this would be to use the Simple formatter https://docs.rs/uuid/latest/uuid/fmt/struct.Simple.html
There was a problem hiding this comment.
Could just be trace_id.simple() and then the Display trait will handle things correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we need to remove dashes from the trace_id when we create the trace header. adds assertions on the number of dashes to assure correct format.