feat: Implement basic producer #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wedamija
commented
Jun 7, 2024
src/producer.rs
Outdated
Comment on lines
22
to
23
| topic: Topic, | ||
| config: KafkaConfig, |
There was a problem hiding this comment.
It might make sense for this to not have to accept the topic/config, and for us to have it set up somewhere
There was a problem hiding this comment.
Yeah I agree, we can just put this method on a struct and load it in there
evanpurkhiser
approved these changes
Jun 7, 2024
This implements the basics of a producer for sending results back to sentry.
wedamija
force-pushed
the
danf/result-producer
branch
from
7c3c435 to
da568f7
Compare
src/scheduler.rs
Outdated
| // TODO: Producer should be instantiated with these values and shared | ||
| let config = KafkaConfig::new_config(["0.0.0.0".to_string()].to_vec(), None); | ||
| let topic = Topic::new("uptime-checker-results"); | ||
| let _ = produce_checker_result(&check_result, topic, config).await; |
There was a problem hiding this comment.
nice, let's move the config outside of the function though I think.
If you address the earlier comment of making a ResultsProducer struct we can pull that out also (will need to wrap in Arc)
Once #43 is merged we can pass the config into run_scheduler and it can construct the KafkaConfig from that
evanpurkhiser
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the basics of a producer for sending results back to sentry.