fix(cli): Avoid abort listener fanout#336
Merged
Merged
Conversation
Share abort listeners across composed skill tasks so large trigger sets do not attach one listener per task to the same fail-fast or circuit-breaker signal. Co-Authored-By: GPT-5 <[email protected]>
dcramer
force-pushed
the
fix/abort-listener-fanout
branch
from
b9987e6 to
67a959e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warden now shares fail-fast and circuit-breaker abort listeners across composed skill tasks instead of attaching one listener per task to the same shared signal. Large runs with many matched triggers no longer trip Node's MaxListenersExceededWarning while preserving abort propagation for SIGINT, fail-fast, and provider circuit breaker stops.
Abort Composition
Task-specific abort controllers are still composed with shared run-level abort sources, but shared sources are listened to once and then fan out internally. Reused task abort controllers are cached so repeated references do not add duplicate listeners.
Regression Coverage
The task runner tests now assert listener counts stay bounded for 12 composed tasks and that abort propagation still reaches every composed task controller.