Skip to content

DEN-5827: Fix GHSA-r6ph-v2qm-q3c2: Upgrade cryptography to 46.0.5#302

Merged
fabioueno merged 2 commits intomasterfrom
copilot/den-5827-fix-cryptography-vulnerability
Feb 11, 2026
Merged

DEN-5827: Fix GHSA-r6ph-v2qm-q3c2: Upgrade cryptography to 46.0.5#302
fabioueno merged 2 commits intomasterfrom
copilot/den-5827-fix-cryptography-vulnerability

Conversation

Copy link
Contributor

Copilot AI commented Feb 11, 2026

Proposed change

Addresses HIGH severity vulnerability (GHSA-r6ph-v2qm-q3c2) in cryptography package - missing subgroup validation for SECT curves enabling subgroup attacks.

Implementation Reasoning:
Upgrading the cryptography package to 46.0.5 which includes proper subgroup validation for SECT curves, preventing subgroup attacks. This is a direct dependency upgrade - straightforward version bump in pyproject.toml (if specified) and lock file regeneration with uv. Using uv's --upgrade-package flag ensures only cryptography and its direct dependencies are updated, minimizing risk of unintended changes.

Changes:

  • uv.lock: cryptography 46.0.4 → 46.0.5

References:

How to test the change

# Verify version in lock file
grep -A2 'name = "cryptography"' uv.lock | grep version

# Run test suite
uv sync --extra dev
uv run pytest

Checklist

  • Tests have been added to verify that the new code works (if possible)
  • Documentation has been updated to reflect changes
  • CHANGELOG.md has been updated to reflect changes

cc @fabioueno for review

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • astral.sh
    • Triggering command: /usr/bin/curl curl -LsSf REDACTED (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

Create a branch named den-5827-fix-cryptography-vulnerability

Jira Ticket: DEN-5827
Security Alert: Github_Security_Alert - cryptography Vulnerable to a Subgroup Attack Due to Missing Subgroup Validation for SECT Curves

Context:
This is a security vulnerability fix for GHSA-r6ph-v2qm-q3c2 in the cryptography package used by the auto-pr tool.

Vulnerability Details:

  • CVE/GHSA: GHSA-r6ph-v2qm-q3c2
  • Severity: HIGH
  • Package: cryptography
  • Vulnerable Version/Range: <= 46.0.4
  • Patched Version: 46.0.5

Work Needed:

  • Locate the cryptography dependency in pyproject.toml or uv.lock
  • Upgrade cryptography from current version (<= 46.0.4) to patched version 46.0.5
  • Update uv.lock file by running uv lock --upgrade-package cryptography or uv sync --upgrade-package cryptography
  • Verify patched version 46.0.5 appears in uv.lock
  • Run tests following repository's documented test process (check README.md, Makefile, or CI workflows in .github/workflows/)

⚠️ PR Description Requirements:

  • ALWAYS include the "Implementation Reasoning" section below in the PR description on GitHub

Implementation Reasoning:
Upgrading the cryptography package to 46.0.5 which includes proper subgroup validation for SECT curves, preventing subgroup attacks. This is a direct dependency upgrade - straightforward version bump in pyproject.toml (if specified) and lock file regeneration with uv. Using uv's --upgrade-package flag ensures only cryptography and its direct dependencies are updated, minimizing risk of unintended changes.

Security Considerations:

  • Ensure cryptography 46.0.5 actually appears in uv.lock after the update
  • Run all tests to verify no breaking changes
  • This fix addresses a HIGH severity vulnerability related to elliptic curve cryptography

Acceptance Criteria:

⚠️ Security Fix: This PR addresses a HIGH severity vulnerability in elliptic curve cryptography. Please review carefully.

Ask @fabioueno for a review.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@gygrobot gygrobot requested a review from fabioueno February 11, 2026 12:22
@gyg-pr-tool gyg-pr-tool bot changed the title [WIP] Fix cryptography vulnerability due to missing subgroup validation DEN-5827: [WIP] Fix cryptography vulnerability due to missing subgroup validation Feb 11, 2026
Copilot AI changed the title DEN-5827: [WIP] Fix cryptography vulnerability due to missing subgroup validation Fix GHSA-r6ph-v2qm-q3c2: Upgrade cryptography to 46.0.5 Feb 11, 2026
@gygrobot gygrobot marked this pull request as ready for review February 11, 2026 12:27
@gygrobot gygrobot requested a review from a team as a code owner February 11, 2026 12:27
Copilot AI requested a review from gygrobot February 11, 2026 12:27
@gyg-pr-tool gyg-pr-tool bot changed the title Fix GHSA-r6ph-v2qm-q3c2: Upgrade cryptography to 46.0.5 DEN-5827: Fix GHSA-r6ph-v2qm-q3c2: Upgrade cryptography to 46.0.5 Feb 11, 2026
@fabioueno fabioueno merged commit a9b7e62 into master Feb 11, 2026
6 checks passed
@fabioueno fabioueno deleted the copilot/den-5827-fix-cryptography-vulnerability branch February 11, 2026 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants