-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add mesh shading api to wgpu & wgpu-core #7345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Add mesh shading api to wgpu & wgpu-core #7345
Conversation
…moved accidentally commited test-output.txt
… also broken, just trying to get CI to report compile errors
This PR got stuck a while back because I was too lazy to go through and understand |
Question regarding mesh shaders in general: is it crucial that good validation is added immediately with PRs? This PR adds some but I suspect that there would be some validation that might be more of a pain to add, and also require some research to determine good defaults/recommended values. |
Connections
#7197
Description
Adds a mesh shading api to wgpu and wgpu-core so that further tests/examples/progress can be made.
This is a rather large PR. If it needs to be split up, I suppose that could be done, but the individual parts all kind of interact. Also doesn't help that I've never tried to split up a branch/PR.
Remaining work is all in limits. There are a lot of limits in https://registry.khronos.org/vulkan/specs/latest/man/html/VkPhysicalDeviceMeshShaderPropertiesEXT.html, many of which will be relevant, though plenty of it for naga. I will only try to use the limits we currently need for validation, rather than try to guess which will be useful.
Testing
This change currently has several tests plus an example.
Squash or Rebase?
Not sure about this honestly, due to inexperience with git.
Checklist
cargo fmt
.taplo format
.cargo clippy
. If applicable, add:--target wasm32-unknown-unknown
cargo xtask test
to run tests.CHANGELOG.md
entry.