[deno] Rework error and device loss handling #7693
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of these changes is to make the CTS work again under deno, see #6838 and #7675.
There are two things happening here:
device.lost
should always return the same promise.V8TaskSpawner
is used to schedule error handling through the runtime.Testing
Tested using the
webgpu:api,operation,device,lost:*
andwebgpu:api,operation,uncapturederror:*
CTS tests. However, additional changes are needed to get the CTS to work, so until the rest of those changes are made, there isn't a mechanism to test this in the wgpu tree (that I'm aware of).Squash or Rebase? Squash
Checklist
cargo fmt
.taplo format
.cargo clippy --tests
. If applicable, add:--target wasm32-unknown-unknown
cargo xtask test
to run tests.CHANGELOG.md
entry.