Convert as_hal calls to use guards intead of callbacks
#7863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
changed the title
as_hal calls to use guards intead of callbacks
cwfitzgerald
force-pushed
the
cw/as_hal_guards
branch
2 times, most recently
from
e57540a to
f58ac37
Compare
Vecvec
reviewed
Jun 29, 2025
|
I'm not the one doing the review, I just noticed a typo. |
cwfitzgerald
force-pushed
the
cw/as_hal_guards
branch
from
f58ac37 to
946983e
Compare
|
Do you still have to unwrap() manually in case of backend API mismatch? |
Yes all apis return options. |
|
I'd rather it unwrap in wgpu, personally. I can't imagine why you would want it to be optional. Users are likely going to perform a backend check higher-up, and switch between e.g. dlss_vk and dlss_dx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This converts all
as_halcalls (except CommandBuffers) from callbacks to guards. This will make the api signifigantly better.I needed to add a few escape hatches in the locking infrastructure to allow dependent locks to exist in a single guard. All of the unsafe in this PR does not affect Mozilla.
Review experience is commit by commit
Testing
No current testing of the as_hal api at all. Working on it.
Squash or Rebase?
Rebase
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.