[types] Replace conditional derive(thiserror::Error) with unconditional impl.
#8384
+23
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onal `impl`. This is two changes in one: * Make `PollError` always implement `Error`. * Remove the dependency on `thiserror`, even though we use it elsewhere, because having shorter chains of dependencies is good for build parallelism.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Fixes #8380.
Description
This is two changes in one:
PollErroralways implementError(fixesthiserrorshould be used unconditionally #8380).thiserror, even though we use it elsewhere, because having shorter chains of dependencies is good for build parallelism.Testing
Reviewed documentation to confirm that the
Errorimplementation is present as it should be.Squash or Rebase?
Rebase
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.