vulkan: implement more backpropagation operators #11914
Open
+233
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Vulkan
|
The backend tests all pass for me (RTX 4070). I reviewed the code, though I didn't review the shader calculations in great detail. |
jeffbolznv
approved these changes
Feb 17, 2025
remyoudompheng
force-pushed
the
vulkan-ggmlopt2
branch
from
1b2b86a to
6c5753f
Compare
|
Rebased to solve conflicts with #11769 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to #11769
It implements the following ops for Vulkan:
Shaders are mostly copy-pasted from CUDA kernels with inspiration from existing Vulkan shaders for wg sizes.
ROPE_BACK is implemented using the existing RoPE shader (but with negative angle).