Bump ROCm versions, re-enable in GHA #14098
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
devops
Is this a problem on our end or? |
Unfortunately I don't know. My skills in c++ and this sort of programming (GPU) are fairly low - I know there have been some issues with memory allocation with HIP/ROCm in the past (e.g #13698) but I don't really know where to start. |
|
This pr is generally fine, but lets investigate @gremlinofthemysticarts problem first. I cant reproduce this on my machine atm. @gremlinofthemysticarts could you file an issue with more information on your setup and what your are trying to do to aid in repoduction? |
|
Will do! |
|
Created issue as #14178 |
|
Superseded by #14184 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems to issue with compilation has been resolved, as I can build locally. However, ROCm memory detection seems to be broken, with models only being able to use ~600MiB of video memory.