Skip to content

server : fix assistant prefilling when content is an array #14360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 5, 2025

Conversation

CISC
Copy link
Collaborator

@CISC CISC commented Jun 24, 2025

Assistant prefilling did not account for content as an array.

@CISC
Copy link
Collaborator Author

CISC commented Jun 24, 2025

Oops, looks like this requires more work.

@CISC CISC marked this pull request as draft June 24, 2025 10:08
@CISC CISC marked this pull request as ready for review June 24, 2025 10:31
@CISC
Copy link
Collaborator Author

CISC commented Jun 24, 2025

@ngxson Welcome back, hope you're feeling better.

@github-actions github-actions bot added the python python script changes label Jun 24, 2025
@CISC
Copy link
Collaborator Author

CISC commented Jul 4, 2025

@ngxson gentle ping

@CISC CISC merged commit ddef995 into master Jul 5, 2025
51 checks passed
@CISC CISC deleted the cisc/assistant-prefilling-content-array branch July 5, 2025 07:17
Minh141120 pushed a commit to menloresearch/llama.cpp that referenced this pull request Jul 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples python python script changes server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misc. bug: llama-server assistant prefill only works when message content is a string (not a list of objects)
2 participants