model : add PLaMo-2 model #14560
model : add PLaMo-2 model #14560
Conversation
This will be necessary to support Jamba (and other recurrent models mixed with Attention). Doesn't compile yet, and finding a slot isn't yet done correctly for recurrent states.
* llama : begin work on support for variable GQA This will also be useful for Jamba if we consider the Mamba layers to have 0 KV heads. * llama : gracefully fail when not finding hybrid slot
* ggml : simplify SSM-related operators * llama : make recurrent state slot allocation contiguous * llama : adapt internal uses of batches to llama_ubatch
This reduces overhead when running hellaswag on thousands of sequences with very small 100k params Mamba models.
This otherwise was a problem when running the HellaSwag benchmark with small batch sizes, making it crash.
This removes the need for ggml_ssm_conv!!! But performance seems slighly worse on my system, especially for prompt processing. Maybe ggml_mul_mat isn't optimized for small row sizes? More performance testing is necessary until GGML_OP_SSM_CONV is removed. * ggml : make ggml_ssm_scan not modify its source tensors * llama : fix shared recurrent tail cell count for small ubatch sizes Otherwise it was impossible to run the 'parallel' example with '-ub 1' with a Mamba or Jamba model.
* ggml : allow GGML_OP_CONCAT to work on non-contiguous tensors The implementation already supported it, and this makes Mamba's conv step slightly faster.
This can be changed back later if the name change is wrong. I was renaming the functions anyway to generalize kv-cache-related functions to hybrid and recurrent model architectures. I think llama_past is a better name than llama_cache for a combined kv cache and recurrent state cache, because the states it contains pretty much always come before the newly-added ones for any particular sequence. Also 'llama_past_clear' sounds more obvious in what it does than 'llama_kv_cache_clear'. The future is what the models generate. (For embeddings, the kv cache isn't really used anyway) Still, I'm open to better suggestions.
| // PLaMo-2 Aho-Corasick tokenizer | ||
| class llama_vocab_plamo2 { | ||
| public: |
There was a problem hiding this comment.
I am not convinced that we have to add this new implementation.
Can you provide a reference for the PlaMo-2 tokenizer so we can understand how it differs from the existing tokenizer algorithms?
There was a problem hiding this comment.
I appreciate you asking for a reference for the PlaMo-2 tokenizer to better understand how it differs from existing algorithms. The original implementation can be found at the following Hugging Face repository:
Original PlaMo-2 Tokenizer Implementation:
https://huggingface.co/pfnet/plamo-2-8b/blob/main/tokenization_plamo.py
I hope this clarifies the unique aspects of this tokenizer. I'm happy to discuss the necessity of this new implementation further.
|
Sir, you're a gentleman and a scholar. It indeed seems to work, in Q8_0 as well. Only caveat is that I had to set add_special=True in the server for the <|plamo:op|> token to appear+act as a stop token (as shown by the -sp option in the llama-cli command line above). |
mitmul
force-pushed
the
mitmul/add-plamo2
branch
from
ceaa6a2 to
fccec6d
Compare
Thank you for testing this PR. As for the special token This makes the |
Co-authored-by: Sigbjørn Skjæret <[email protected]>
Co-authored-by: Sigbjørn Skjæret <[email protected]>
Co-authored-by: Sigbjørn Skjæret <[email protected]>
This PR supports PLaMo2 model in llama.cpp, which was also requested on a related discussion thread: #13874. This model uses a custom-implemented tokenizer, so this PR includes both the model itself (which uses an architecture combining Mamba and Attention, similar to Jamba) as well as implementing the new custom tokenizer.
Based on #7531
How to check if the plamo-2-translate works with this PR. First, retrieve the model itself by:
Then, I needed to modify the
tokenizer.jsonlto pad some meaningless vocabs to align the vocabulary size to what is specified inconfig.json, namely it should be 100032 by using this script:Next, convert the model into gguf by the following command:
Then build binaries as follows:
and finally, I successfully run the plamo-2-translate model as follows:
./release/bin/llama-cli -m plamo-2-translate.gguf -p "<|plamo:op|>dataset\ntranslation\n<|plamo:op|>input lang=English\nHello, how are you?\n<|plamo:op|>output\n" -no-cnv --verbose-prompt --no-warmup -spintermediate outputs
Output:
Seems correctly working!