ggml-cuda: HIP replace __shfl_xor_sync with dpp instructions - #26466
Draft
thelittlefireman wants to merge 1 commit into
Draft
ggml-cuda: HIP replace __shfl_xor_sync with dpp instructions#26466thelittlefireman wants to merge 1 commit into
thelittlefireman wants to merge 1 commit into
Conversation
Sure thing! You or anyone else, are welcome to use this code as they see fit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Change
__shfl_xor_syncto dpp instructions for little speed on HIP.Additional information
The original code is not mine it was proposed by @maximumbusdatatype in the PR
16291
I add compatibility for architecture == GFX9. Cause row_share
hip_move_dpp<0x160 + X>and row_xmask are not supported before GFX10Benchmark:
master
This PR
@maximumbusdatatype: Do you agree to use this code ?
Requirements
Currently only a DRAFT. Benchmark and clean description will follow.