Fix issue where tool arguments can appear in any JSON-valid order - #26472
Open
i386 wants to merge 1 commit into
Open
Fix issue where tool arguments can appear in any JSON-valid order#26472i386 wants to merge 1 commit into
i386 wants to merge 1 commit into
Conversation
…s in any order that is valid json. Required fields are still enforced and duplicate args are forbidden. Tests cover reordered fields, missing required fields, and duplicates. Assisted-by: Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The original code imposed an ordering rule that JSON objects do not have. This caused llama.cpp’s tagged tool-call output parser to reject sequences whose argument tags did not follow its strict required-before-optional ordering.
Requirements