Deepseek 4: -sm tensor - #26490
Open
am17an wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
testing
Contributor
Author
|
@gaugarg-nv since Johannes is busy would you mind reviewing this PR? |
gaugarg-nv
reviewed
Aug 3, 2026
Comment on lines
-427
to
-429
| if (arch == LLM_ARCH_DEEPSEEK4) { | ||
| return false; | ||
| } |
Contributor
There was a problem hiding this comment.
WebGPU backend seem to be failing with this change in CI. can you check?
Contributor
Author
There was a problem hiding this comment.
WebGPU can't handle any change in test-llama-archs so I would just ignore this for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add
-sm tensorfor DeepSeek4. The FA is mirrored because there is only 1 K head (Q has 64). Apart from that addmemset_tensoris added to the meta backend.Additional information
on 4x 4090s I see a PP increase of 50% but TG does not increase.
Requirements