Skip to content

Conversation

@abdullhakim-sami
Copy link

@abdullhakim-sami abdullhakim-sami commented Jun 18, 2025

@netlify
Copy link

netlify bot commented Jun 18, 2025

Deploy Preview for sketch-gleam canceled.

Name Link
🔨 Latest commit fb74437
🔍 Latest deploy log https://app.netlify.com/projects/sketch-gleam/deploys/686e4e6de8a00f000871730f

@ghivert
Copy link
Owner

ghivert commented Jun 18, 2025

Thanks!

Could you use element.unsafe_raw_html instead of vnode? vnode is an internal module, and as such, it should not be used in an other package.

Could you also add a link to the Lustre documentation in the docstring too?

@abdullhakim-sami
Copy link
Author

Sorry for taking long was procrastinating doing this !

@ghivert
Copy link
Owner

ghivert commented Jul 31, 2025

Sorry for taking so long to review.

I think it would be better to have the css.Class as the first argument. That way we stay consistent with the rest of Sketch, and this simplify the pipe ability.

css.class([])
|> el.unsafe_raw_html(namespace, tag, attributes, children)

Also, could you rebase and clear your history. You have 4 commits, while you can squash everything as one commit. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

You can't use unsafe raw html with sketch

3 participants