Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS] feat: Add setting to hide icon from dock/cmd-tab #5122

Merged
merged 1 commit into from
Feb 15, 2025

Conversation

xalbd
Copy link
Contributor

@xalbd xalbd commented Jan 15, 2025

Resolves #4538

Adds boolean configuration option macos-hidden which toggles the NSApp's activation policy appropriately on config change.

Copy link
Contributor

@AlexJuca AlexJuca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thanks

@mitchellh mitchellh requested a review from a team as a code owner February 15, 2025 18:45
@mitchellh
Copy link
Contributor

I changed the config to an enum so we can easily accommodate the quick-terminal value in the future (as noted in #4538). Otherwise, looks great. Running CI then will merge.

@mitchellh mitchellh enabled auto-merge February 15, 2025 18:50
@mitchellh mitchellh merged commit 6d8db4b into ghostty-org:main Feb 15, 2025
28 checks passed
@github-actions github-actions bot added this to the 1.2.0 milestone Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

macOS: Introduce config to hide Ghostty from the dock and cmd-tab
4 participants