feat(generic-card): make generic card from download card #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
BrandonRomano
approved these changes
Dec 28, 2024
| <div className={s.buttons}>{children}</div> | ||
| </div> | ||
| ); | ||
| } |
There was a problem hiding this comment.
We should also remove the corresponding .downloadCard styles inside of the DownloadPage.module.css file.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
hoists the
DownloadCardcomponent to it's ownGenericCardcomponent for future use. This component will probably be extended with the work on the Showcase pageNote
This is a recreation of #129 because GH did not like the transition from private > public repo 🥴
Why?
To tackle #125, My plan is a "grid" of cards with an image, title and description (possibly a modal to open config etc). Instead of re-creating something, moving this card component made sense.
Images/Video
Download page (unchanged as this is a component move but screenshotting for validity)
Notes