Subplots are removed when selecting other items in the canvas #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* allow to choose the gridaxis color of the plot * fix test? * Update DataPlotly/core/plot_types/plot_type.py Co-authored-by: Simon Gröchenig <[email protected]> * Apply suggestions from code review Co-authored-by: Simon Gröchenig <[email protected]> Co-authored-by: Nyall Dawson <[email protected]> * use hex color strings and lowerize all of them. fix tests? Co-authored-by: Simon Gröchenig <[email protected]> Co-authored-by: Nyall Dawson <[email protected]>
To avoid empty space above layout option group
move layout properties to layout options group in widget
This reverts commit a5a1d44.
|
Hi Matteo,
I have made an issue of this possible bug a few days ago, as you asked.
I hope it is clear to you. If not please ask me to clarify things. I’m not familiar with GitHub, so please don’t hesitate if I am doing something wrong.
I’m in doubt what to do based on the fact I don’t know what the follow-up is:
* Is it a bug or do I something wrong?
* Are you going to fix it, if it is a bug?
* If so, on what timescale do you think you are going to solve it?
Depending on your answer I can take further action.
Hope to hear from you.
Regards,
Coen van Tooren
------------------------------------------------
E: ***@***.*** ***@***.***>
LI: https://www.linkedin.com/in/coenvantooren/
A: Prof. Hugo de Vrieslaan 49
PC: 3571 GG Utrecht
M. 06 - 168 20 375
KvK: 30199151
…------------------------------------------------
Mobiliteit Informatie Systeem <http://vuurtooren.nl/mobiliteit-informatie-systeem/> Mobiliteitsbeleid <http://vuurtooren.nl/ontwikkelen-mobiliteitsbeleid/> Home <http://vuurtooren.nl/> Over <http://vuurtooren.nl/over/>
Van: Matteo Ghetta ***@***.***>
Verzonden: vrijdag 17 september 2021 08:15
Aan: ghtmtt/DataPlotly ***@***.***>
CC: Coen ***@***.***>; Mention ***@***.***>
Onderwerp: Re: [ghtmtt/DataPlotly] Subplots are removed when selecting other items in the canvas (#264)
@CvTooren <https://github.com/CvTooren> I think you hit a bug. Can you please open an issue <https://github.com/ghtmtt/DataPlotly/issues> rather a pull request? Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#264 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACUPIRWCDHDF7ZJHEPSUUS3UCLMGPANCNFSM5EERZBJQ> .
Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub> . <https://github.com/notifications/beacon/ACUPIRX5MQZ4J4QZBBURLQDUCLMGPA5CNFSM5EERZBJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOG3WWSBA.gif>
|
* Expose Dataplotly on QGIS Server for a GetPrint request * Fix tests about lint
Float now requires explicit cast to int
* Add options to change title, xticks and yticks font sizes. Insert options in graph parameters to change settings for all three parameters. Could be refined to also change x_label and y_label font sizes (if such parameters exist) * Add options for x/y labels and put all box in a collapsible group * Update UI parameters (title, collapsed state, default values) * Update default font size (ui and python). * Use QgsFontButton instead of size input only. Still needs some work to keep in mind the parameters between two sessions. * Separate parameters into family, size and color * Test if font related settings are correctly stored and restored. * Fix pylint issues Co-authored-by: Matthieu Denoux <[email protected]>
Co-authored-by: julien.monticolo <[email protected]>
* Fix "Build a generic plot" processing algorithm * Update DataPlotly/processing/dataplotly_algorithms.py
…288) * new custom function to get the colors from categories used * update the expression to be more generic
* using plotly.express provider and scatterplot algorithm * json output optional * fix lint * remove useless utils file * fix lint again * add faceting
* add icon and remove some useless methods and strings * add Processing test for scatterplot * update changelog * update copy info (thanks Etienne :) ) * lint * add pandas to the requirement testing packages * fix test with self.maxDiff * use json instead of html for test, too unpredictable * remove useless function * try another test approach
* add bar width with custom data and standard value * update the attribute table of the test layer * restore label and marker size when the scatter plot is chosen
* version control ignores vscode settings * first implementation * add dock_id argument to loadDocFromDic * disconnect signals when unloading * try to create plot immediatly after dock init * docks state and geometry can be restored from project * remove extra comma * feat : add new dock * dock_title can be restored too * dock title with space can be restored now * resize add_dock_dlg * feat : implementation remove dock * fix: main dataplotly panel read_from_project * Update .gitignore Co-authored-by: Matteo Ghetta <[email protected]> * Update DataPlotly/data_plotly.py Co-authored-by: Matteo Ghetta <[email protected]> * Update DataPlotly/gui/remove_dock_dlg.py Co-authored-by: Matteo Ghetta <[email protected]> * Update DataPlotly/data_plotly.py Co-authored-by: Matteo Ghetta <[email protected]> * fix : remove the return value dlg * pylint : start remove unnecessary import and define variable in init * move utils functoin in core_utils * move restore in core_utils * style : pylint * format: pylint * format: pylint * format: pylint * format : pylint * format: pylint * test: add removeDockWidget to QgisInterface * test : add override_iface to DataPlotlyDock const * test : add first tests to dock_manager * test : add other tests * style: pylint use-dict-literal * style: pylint remove superflous parens * test: add test on utils xml function * ignore .qgs~ * test : add test on DataPlotlyNewDockIdValidator * Update .gitignore * Update DataPlotly/test/test_dock_manager.py * fix pycodestyle --------- Co-authored-by: Jean-Daniel LOMENEDE <[email protected]> Co-authored-by: Matteo Ghetta <[email protected]>
* feat : call create_plot when project is readed * feat: clear plot view when project is cleared * style: pylint
* feat: add hole option to pie chart * style: pylint * fix: limit pie_hole to 0.95
* set the initial value to Auto, clearValue to Auto and tooltip * tweak the bar width value to pass to plotly * add changelog info * bump new release and minimum QGIS version * no more 3.22 in docker
* Python cleanup, raise to 3.7 minimum due to QGIS 3.28 * Do not use fstring when the string is translated * Update DataPlotly/gui/plot_settings_widget.py
* Deepcopy settings when creating factories Otherwise things get murky when we re-use the same settings objects with multiple factories, as the factory plot generation logic modifies settings (eg by recording the list of found feature ids) Fixes incomplete plots when used with atlas * Simpler fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can create subplots, e.g. scatterplots based on different variables in one QGIS layer. However, as soon as I select another point or area of that layer the different subplots are removed and only the latest plot based on the latest settings is shown. How can I solve this, or is it a bug?